Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License of jsonschema fork in v1 branch? #2949

Open
musicinmybrain opened this issue Nov 15, 2023 · 0 comments
Open

License of jsonschema fork in v1 branch? #2949

musicinmybrain opened this issue Nov 15, 2023 · 0 comments
Labels
researching Researching the issue

Comments

@musicinmybrain
Copy link
Contributor

CloudFormation Lint Version

cfn-lint 1.2.0.a1

What operating system are you using?

Fedora Linux

Describe the bug

Given that most of the code in src/cfnlint/jsonschema in the v1 branch is derived from https://github.com/python-jsonschema/jsonschema, which is available under a standard MIT license, can these files really be said to be available under the overall MIT-0 license? The MIT license has attribution requirements (“The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.”) that don’t seem to be respected here.

SPDX-License-Identifier: MIT-0

# Code is taken from jsonschema package and adapted CloudFormation use
# https://github.com/python-jsonschema/jsonschema

Expected behavior

The attribution requirements of the original jsonschema license are respected, or if its authors agreed to make it available under MIT-0 for use in cfn-lint, this is clearly indicated.

Reproduction template

N/A

@kddejong kddejong added the researching Researching the issue label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
researching Researching the issue
Projects
None yet
Development

No branches or pull requests

2 participants