Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow docker to be used in the config #390

Open
jpSimkins opened this issue Apr 29, 2024 · 0 comments
Open

Feature Request: Allow docker to be used in the config #390

jpSimkins opened this issue Apr 29, 2024 · 0 comments

Comments

@jpSimkins
Copy link

jpSimkins commented Apr 29, 2024

I am wanting to use docker and integrate it into this vscode extension rather than having to install packages locally.

This eases onboarding and prevents issues with other projects/packages that may be installed on a users computer.

I have this working for manually processing the scripts but it would be ideal if I could modify the config to point to docker instead of a local installation.

{
  "cfnLint.path": "docker run -v $(pwd)/:/data -t mysteriouscode/cfn-lint"
}

Currently, if I do try to pass docker, I get an error due to the space after docker. Given that is a path, I would expect this to be the case.

I currently use scripts to do the linting:

{
  "scripts": {
    "Tools:": "echo \"Nothing to see here\" && exit 1",
    " - cfn-lint": "docker run -v $(pwd)/:/data -t mysteriouscode/cfn-lint --config-file /data/.config/cfn-lint/.cfnlintrc.yaml",
    "Debug:": "echo \"Nothing to see here\" && exit 1",
    " - cfn-lint:version": "docker run -v $(pwd)/:/data -t mysteriouscode/cfn-lint --version"
  }
}

Please consider adding this capability. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant