Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate IconChar entries in property window. #97

Open
Sensei6x9 opened this issue Aug 6, 2022 · 8 comments
Open

Duplicate IconChar entries in property window. #97

Sensei6x9 opened this issue Aug 6, 2022 · 8 comments

Comments

@Sensei6x9
Copy link

Describe the bug
There are some duplication of IconChars in the property window.

To Reproduce
Steps to reproduce the behavior:

  1. Create VB.Net (BASIC) Project
  2. Install FA.Sharp v6.1.1
  3. Add IconButton
  4. Navigate to IconChar in property window.
  5. See Error (duplicate IconChars i.e. DollarSign, FloppyDisk, etc.)

Expected behavior
Information on why there are duplicates and maybe deletion of the said duplicates.

Screenshots
image
image

@mkoertgen
Copy link
Member

mkoertgen commented Aug 8, 2022

Hi @Sensei6x9 ,

I can see duplicate enum values for DollarSign in IconChar.cs as well as in the Professional-icons (DuoTone, ProIcons), cf.:

FloppyDisk only found once in code.

Will check on reproducing the bug.

@Sensei6x9
Copy link
Author

Thanks @mkoertgen . I'm using only the free one, I guess that why I can only use one of those duplicates.

@mkoertgen
Copy link
Member

I can confirm this reproducing it using VS2022 / WinForms net6-windows and the latest NuGet package

Lots of duplicate all through the collection
image

@mkoertgen
Copy link
Member

Added a unit test reproducing the error. In fact Enum.GetValues(...). -> ToString() may produce lots of duplicates.

@mkoertgen mkoertgen added this to the 6.1.2 milestone Aug 11, 2022
@mkoertgen mkoertgen added this to To do in FontAwesome.Sharp via automation Aug 11, 2022
@mkoertgen mkoertgen moved this from To do to Reviewer approved in FontAwesome.Sharp Aug 11, 2022
@Sensei6x9
Copy link
Author

I don't know what to do from here on out.... still new to github and I'm only here because of your awesome icons (thanks btw)

@mkoertgen
Copy link
Member

Hi @Sensei6x9 ,

No problem, thanks for bringing this to my attention. The bug is fixed, yet for the next release I wanted to compile some other fixes as well.

See milestone 6.1.2 which should be released by this week.

Ok for you?

@Sensei6x9
Copy link
Author

I see, yeah that's great. Thank you so much.

@mkoertgen mkoertgen removed this from the 6.1.2 milestone Dec 21, 2022
@duckdoom5
Copy link

duckdoom5 commented Jan 27, 2024

The issue is still apparent in a different form. Not sure if you fixed it elsewhere, but the main branch still has duplicate entries.
image
image

(Note that this is only an intellisense error and compiles just fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
FontAwesome.Sharp
Reviewer approved
Development

No branches or pull requests

3 participants