Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls stopPropagation even when no key combo applies #67

Open
leebyron opened this issue Jul 19, 2018 · 1 comment
Open

Calls stopPropagation even when no key combo applies #67

leebyron opened this issue Jul 19, 2018 · 1 comment

Comments

@leebyron
Copy link

I've noticed that because react-shortcuts overrides combokey's handleKey method, it doesn't check to see if a key combo in the key map actually applies before applying logic to preventDefault or stopPropagation. Since the stopPropagation prop defaults to true, this can result in other components on the page which react to keyboard events (like a select combo box) to stop receiving events, even though they don't interfere with the registered key combos.

@leebyron
Copy link
Author

I see that the isolate prop was added to help with this scenario, but since it defaults to false, it creates an API where the minimal use case introduces this sort of bug.

Should isolate be true by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant