Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【an error】 #3

Open
slbcs opened this issue Oct 23, 2015 · 1 comment
Open

【an error】 #3

slbcs opened this issue Oct 23, 2015 · 1 comment

Comments

@slbcs
Copy link

slbcs commented Oct 23, 2015

I am so sorry to trouble you, as I found a problem in your code,when you try to calculate R and t. First, you calculate t_f and then calculate R_f (By using 1. t_f = t_f + scale_(R_f_t);
2.R_f = R_R_f in you code) .What's more, I think you made the wrong order as we should calculate R_f at first and then calculate t_f (By using 1.R_f = R_R_f 2. t_f = t_f + scale_(R_f_t)),which was described in the Constructing Trajectory part of your blog(http://avisingh599.github.io/vision/monocular-vo).
Sorry for my disturbance and thank you very much for your code.I sincerely want to know whether I am right or not and I need your help. Thanks and best wishes!

@kerolex
Copy link

kerolex commented Apr 15, 2016

Actually, inverting the two formulas generates a mistake in the second one: the translation part will be updated based on the new rotation matrix, instead of using the previous one as it should be. From an implementation point of view, if you create two variables prevR and prevT and you replace them in the two formulas, you will see the order does not matter anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants