Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation instructions #7

Open
moranza opened this issue Jul 30, 2017 · 2 comments
Open

installation instructions #7

moranza opened this issue Jul 30, 2017 · 2 comments

Comments

@moranza
Copy link

moranza commented Jul 30, 2017

There are no instructions.
One needs to guess that he's supposed to do npm install but is there anything else?
Because there are errors in the installation when following those steps:

  1. git clone form repository
  2. npm install (with errors)
  3. npm start (throws 'Class 'MiniStore' incorrectly extends base class 'Observable' in node_modules/ngx-bootstrap/mini-ngrx/store.class.d.ts)
@agoiabel
Copy link

agoiabel commented Dec 3, 2017

There is actually an instruction as at today: 3rd December which says: npm start, but the 3rd point above has not been resolved which can not make other developers contribute to the project.
screen shot 2017-12-03 at 07 41 16

@kartikjagdale
Copy link
Member

@agoiabel Thank you for addressing the issue.
I tried to reproduce this issue and yes it seems there is a problem related to RxJS.

ReactiveX/rxjs#2539

It Seems we need to upgrade the libraries with more stables ones.
I will look into it. 👍

Secondly the error about secrets file yes we didn't push the secrets file and every developer who wants to contribute needs to create their own secrets file in order to get the project running.
We also need to mention that in documentation.
Thank you for reporting @moranza 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants