Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MetaMask references to generic wallet #83

Open
george-gkas opened this issue Feb 15, 2023 · 2 comments 路 May be fixed by #84
Open

Replace MetaMask references to generic wallet #83

george-gkas opened this issue Feb 15, 2023 · 2 comments 路 May be fixed by #84

Comments

@george-gkas
Copy link

馃憢 Hello, Ava Labs team. My name is George, and I'm a Frontend Engineer on the Web Extension team of Trust Wallet. We are currently implementing support for testnet faucets into our browser extension wallet, and we would like to redirect our users to https://faucet.avax.network/.

Unfortunately, the current state of https://faucet.avax.network/ presents a MetaMask icon for establishing a wallet connection or adding new networks. This is misleading because users can still use any wallet to interact with the website (e.g., Trust Wallet, Coinbase Wallet, Brave Wallet, etc.). For that reason, we'd like to propose the change of the MetaMask icon to a generic one. In addition, users will be redirected to https://ethereum.org/en/wallets/find-wallet/ rather than MetaMask's website if they still need to install a wallet.

We have already implemented the proposed changes and will open a PR soon. We strongly believe that they will positively impact the project and the community. Below, I've shared a screenshot of the new UI using the generic icon. We are open to talks and any questions you might have. 馃殌

Screenshot 2023-02-15 at 11 50 38 AM
@george-gkas george-gkas linked a pull request Feb 15, 2023 that will close this issue
Open
@nahoc
Copy link
Contributor

nahoc commented Feb 15, 2023

Have you tried looking into https://core.app/tools/testnet-faucet/ -- it's another "official" implementation of the Faucet

@george-gkas
Copy link
Author

Hello @nahoc10 , we did yes, but we concluded that this implementation is a better choice due to its simple UI and the fact that it does not reference other organizations like https://core.app/tools/testnet-faucet/ does with Core.

https://faucet.avax.network/ is just a faucet that provides a universal connect option and no other integrated tools, which is exactly what we are looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace MetaMask icon with a generic one george-gkas/avalanche-faucet
2 participants
@nahoc @george-gkas