Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Way of Serializing Spaces and Samples from Spaces #107

Open
maximilianreimer opened this issue Nov 2, 2021 · 2 comments
Open

Unified Way of Serializing Spaces and Samples from Spaces #107

maximilianreimer opened this issue Nov 2, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@maximilianreimer
Copy link
Contributor

Currently gym.Spaces as well as the sample drawn from them are serialized to JSON in different ways producing duplicated code and incompatible formats at a different places of the program.

Known serialization code locations:

  • dacbench.abstract_benchmark.AbstractBenchmark.load_config(...)
  • dacbench.abstract_env.AbstractEnv.__init__(...)
  • dacbench.container.container_utils.Encoder and dacbench.container.container_utils.Decoder

Related to #91 and #80

@maximilianreimer maximilianreimer added the enhancement New feature or request label Nov 2, 2021
@maximilianreimer maximilianreimer added this to the 0.0.2 milestone Nov 2, 2021
@maximilianreimer maximilianreimer added this to Todo in Containerization via automation Nov 2, 2021
@maximilianreimer
Copy link
Contributor Author

Serialization of Dict Spaces done by AbstractBenchmark does not work properly. See falling tests in https://github.com/automl/DACBench/tree/container_draft/tests/benchmarks

Should be replace by serialization from dacbench.container.container_utils.Encoderanddacbench.container.container_utils.Decoder` and code should be move somewhere else.

The way of storing spaces will change which requires conversion of existing serialized benchmark configs. We should provide a small script that takes care of this.

Summary:

  • Change serialization of spaces in benchmark configs to the one in Encoder / Decoder, maybe extend the classes to handle the whole benchmark config?
  • Add scrip for conversion of old config format to new
  • Convert old benchmark configs.

@TheEimer
Copy link
Contributor

TheEimer commented Dec 2, 2021

We should implement #80 before we tackle this

maximilianreimer added a commit that referenced this issue Dec 8, 2021
Currently, tests are skipped for CMAESBenchmark since serialization does not work yet (#107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants