[tabular, timeseries] Rename cached version file to version.txt from __version__
#4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Innixma
changed the title
version.txt from __version__version.txt from __version__
|
|
Job PR-4203-c5fca48 is done. |
shchur
reviewed
May 16, 2024
| @@ -4152,6 +4152,16 @@ def _load_version_file(cls, path) -> str: | |||
| version = load_str.load(path=version_file_path) | |||
| return version | |||
|
|
|||
| @classmethod | |||
| def _load_version_file_old(cls, path) -> str: | |||
There was a problem hiding this comment.
Maybe we could add the logic of trying both old & new filenames to _load_version_file instead of introducing a new method _load_version_file_old? I feel like the namespace of Predictor already contains quite a few methods.
There was a problem hiding this comment.
fair point, updated
|
|
Job PR-4203-f720197 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #4161
Description of changes:
__version__that contained the AutoGluon version as a string at the time of saving. However, Kaggle doesn't allow files named__version__to be uploaded for an unknown reason.version.txt, while keeping backwards compatibility.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.