Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxWarning: "is" with a literal : warning issued by python #222

Open
mahdialibi opened this issue Jun 3, 2022 · 1 comment
Open

SyntaxWarning: "is" with a literal : warning issued by python #222

mahdialibi opened this issue Jun 3, 2022 · 1 comment

Comments

@mahdialibi
Copy link

This is not an issue but it is a warning when using automatic with python 3.8+ and authomatic 1.0.0
the warning was added in python 3.8
https://docs.python.org/3.8/whatsnew/3.8.html#changes-in-python-behavior

Error

Authomatic_1_0_0/authomatic/core.py:1720: SyntaxWarning: "is" with a literal. Did you mean "=="?
if ProviderClass.supports_jsonp and method is 'GET':

@touilleMan
Copy link
Contributor

This is definitely a bug in the code here:

if ProviderClass.supports_jsonp and method is 'GET':

should be

 if ProviderClass.supports_jsonp and method == 'GET': 

@jensens jensens added this to New: Needs Check in Issue-Management Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issue-Management
  
New: Needs Check
Development

No branches or pull requests

2 participants