Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several methods expect all providers to be inside the authomatic package #120

Open
Kylotan opened this issue Sep 25, 2015 · 1 comment
Open

Comments

@Kylotan
Copy link

Kylotan commented Sep 25, 2015

Functions like 'AuthorizationProvider.type_id' and 'Credentials.provider_type_class' make assumptions about which file or package they're in, which makes it very difficult to extend the system with new Providers. Please consider removing these restrictions, e.g. by replacing the hard-coded indices with hashes or class names, use credentials.provider_class instead of looking it up by name via credentials.provider_type, etc.

@mrichar1
Copy link
Member

After several years of inactivity, authomatic is now under community management, and we have just released a new stable version (1.0.0).

We are now reviewing all issues and PRs and hoping to begin work to solve as many of these as possible.

We are keen to find out which issues still apply, and which PRs are still required/are likely to merge cleanly into the current code. We are aiming to review them all, but any help with prioritisation would be very useful!

If you are still interested in having this issue/PR resolved, or are able to help us work on it, please reply to this message. That way we know which issues are most important to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants