Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: add tests for internal/command/storage_run.go #6744

Open
2 tasks done
mind-ar opened this issue Feb 27, 2024 · 1 comment
Open
2 tasks done

Test: add tests for internal/command/storage_run.go #6744

mind-ar opened this issue Feb 27, 2024 · 1 comment
Assignees
Labels
priority/4/normal Normal priority items

Comments

@mind-ar
Copy link
Collaborator

mind-ar commented Feb 27, 2024

Description

Add unit tests for that file

Use Case

Will be done after release 4.38

Details

No response

Documentation

No response

Pre-Submission Checklist

  • I agree to follow the Code of Conduct

  • I have checked for related issues and checked the documentation

@mind-ar mind-ar added the priority/4/normal Normal priority items label Feb 27, 2024
@mind-ar mind-ar self-assigned this Feb 27, 2024
Copy link

glime-ai bot commented Feb 27, 2024

Please note this response was created using generative AI leveraging previously available information from the repository. This information may be helpful however it is our strong recommendation that you carefully consider the information before blindly applying it.


Based on the context provided, it seems you are looking to add unit tests for a specific file in the Authelia project after the release of version 4.38. To proceed with this, you should follow the testing guidelines outlined by Authelia, which emphasize the importance of meaningful tests rather than just aiming for 100% coverage. Specifically, tests should effectively reflect what they are testing and which part of the code they are testing. For bug fixes, it's required to include a test that fails before the fix and passes after the fix is applied. This requirement is also strongly encouraged for new features, where feasible.

Given that you've checked the documentation and related issues as per the pre-submission checklist, the next steps would involve:

  1. Reviewing the Testing Guidelines: Ensure you are familiar with Authelia's testing guidelines, which can be found here. These guidelines will help you understand the expectations for unit tests in the project.

  2. Setting Up Your Development Environment: Before writing tests, make sure your development environment is set up according to the instructions provided here. This includes setting up authelia-scripts for ease of development.

  3. Writing the Unit Tests: Write the unit tests for the specific file you are targeting. Ensure the tests are meaningful and adhere to the guidelines. Use authelia-scripts unittest to run the unit tests as mentioned in the development guide.

  4. Submitting Your Contribution: Once your tests are ready and you've ensured they pass, follow the contribution process outlined by Authelia for submitting your tests. This will likely involve creating a pull request and having your changes reviewed by the Authelia team.

Remember, the Authelia team encourages contributions and testing, but they also emphasize the quality and relevance of the tests. If you encounter any specific issues or need further clarification while writing your tests, consider reaching out for support through the appropriate channels, such as GitHub Discussions or the contact information provided on the Authelia website.

This comment was generated by Glime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/4/normal Normal priority items
Projects
None yet
Development

No branches or pull requests

1 participant