Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grexie/go-v8 #42

Open
timoshisa opened this issue Feb 14, 2019 · 3 comments
Open

grexie/go-v8 #42

timoshisa opened this issue Feb 14, 2019 · 3 comments

Comments

@timoshisa
Copy link

timoshisa commented Feb 14, 2019

@augustoroman There is a repository in a company which I have now closed which contains an rewrite of your library following the same design patterns you have in your project. Please could you take a look through this repository: grexie/go-v8 and take from it what you think is useful. Please do not attribute copyright to me, it is yours to have.

I had a lot of help from the Lord God in writing the additions I placed in there. He showed me how to write every single line of code.

This code is for you.

@lacombar
Copy link
Collaborator

lacombar commented Mar 6, 2019

What v8 version were you targeting ? You still seem to use v8::V8::CreateSnapshotDataBlob() which has been deprecated in the latest versions.

@timoshisa
Copy link
Author

I’m sorry, I think you’ve got the wrong GitHub Issue. I don’t recall having worked on snapshots except a little tweaking of function names.

@augustoroman
Copy link
Owner

That's very kind, @tbehrsin. I'll keep this issue open for a bit to reference your code as necessary.

@timoshisa timoshisa changed the title behrsin/go-v8 grexie/go-v8 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants