Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv_resize to smaller doesn't set n #171

Open
hagna opened this issue Aug 2, 2023 · 0 comments
Open

kv_resize to smaller doesn't set n #171

hagna opened this issue Aug 2, 2023 · 0 comments

Comments

@hagna
Copy link

hagna commented Aug 2, 2023

Should
#define kv_resize(type, v, s) ((v).m = (s), (v).a = (type*)realloc((v).a, sizeof(type) * (v).m))
Change to
#define kv_resize(type, v, s) ((v).m = (s), (v).n = (s), (v).a = (type*)realloc((v).a, sizeof(type) * (v).m))?

Without that change this:

#include "kvec.h"

int main() {
    kvec_t(int) dynamic_array;
    kv_init(dynamic_array);

    for (int i = 1; i <= 10; ++i) {
        kv_push(int, dynamic_array, i * 10);
    }

    printf("Original Vector:\n");
    for (size_t i = 0; i < kv_size(dynamic_array); ++i) {
        printf("Element %zu: %d\n", i, kv_A(dynamic_array, i));
    }

    size_t new_size = 5;
    kv_resize(int, dynamic_array, new_size);

    printf("\nResized Vector (to a smaller size):\n");
    for (size_t i = 0; i < kv_size(dynamic_array); ++i) {
        printf("Element %zu: %d\n", i, kv_A(dynamic_array, i));
    }

    kv_destroy(dynamic_array);

    return 0;
}

produces this:

Element 0: 10
Element 1: 20
Element 2: 30
Element 3: 40
Element 4: 50
Element 5: 60
Element 6: 70
Element 7: 80
Element 8: 90
Element 9: 100

Resized Vector (to a smaller size):
Element 0: 10
Element 1: 20
Element 2: 30
Element 3: 40
Element 4: 50
Element 5: 60
Element 6: 49
Element 7: 0
Element 8: 1586204044
Element 9: 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant