Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoiding floating point math in khash #131

Open
larseggert opened this issue Jul 10, 2019 · 1 comment
Open

Avoiding floating point math in khash #131

larseggert opened this issue Jul 10, 2019 · 1 comment

Comments

@larseggert
Copy link

larseggert commented Jul 10, 2019 •
edited

It would be extremely nice for potential use on embedded devices if floating point math (i.e., use of __ac_HASH_UPPER and addition of 0.5) could be avoided in khash.

If that is not possible, it would be quite a bit better already if __ac_HASH_UPPER became a float, at least as an option/define.

WDYT? Are you open to a PR for either of those two?
@larseggert
Copy link
Author

See #132 for a PR of the second alternative (i.e., single-precision math).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@larseggert