Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kann_class_error() is broken for KANN_C_CEB #34

Open
grahamgower opened this issue Mar 15, 2020 · 3 comments · May be fixed by #35
Open

kann_class_error() is broken for KANN_C_CEB #34

grahamgower opened this issue Mar 15, 2020 · 3 comments · May be fixed by #35

Comments

@grahamgower
Copy link

kann_class_error() always returns 0 for networks with KANN_C_CEB cost.
@attractivechaos
Copy link
Owner

kann_class_error() doesn't work with binary cross-entropy KANN_C_CEB. With this cost, there can be multiple 1s, but kann_class_error() assumes there is only one 1.

@grahamgower
Copy link
Author

Yep, thanks. I wasn't sure if this was intentional or not. The mnist-cnn.c example uses KANN_C_CEB with kann_train_fnn1(), which then outputs 0% class error.

@grahamgower
Copy link
Author

Oh, wait. I'm an idiot. :) Sorry for the noise.

grahamgower added a commit to grahamgower/kann that referenced this issue Mar 28, 2020
@grahamgower
Make kann_class_error() work with binary classes.
74517ce 
Closes attractivechaos#34.
@grahamgower grahamgower linked a pull request Mar 28, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make kann_class_error() work with binary classes. grahamgower/kann
2 participants
@attractivechaos @grahamgower