Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sampleRate parameter from instaitiate() to prepare() (BREAKING CHANGE) #163

Open
atsushieno opened this issue Jul 19, 2023 · 0 comments

Comments

@atsushieno
Copy link
Owner

There has been a mismatch between many plugin formats (VST3, AU, CLAP) vs. AAP (and LV2) that sampleRate is required only at setting up a plugin instance (prepareToPlay() in JUCE, setupProcessing() in VST3, activate in CLAP) - or - it is required at instantiation(instantiate in LV2_Descriptor).

AAP had to follow the LV2 way otherwise it will have to populate plugin instance which is quite annoying otherwise, but this eager sampleRate setup also makes it impossible to configure sample rate after instantiating the plugins, which brings in general UX problem - for example, you will have to restructure the entire audio plugin graphs if you want to change the sample rate.

Probably we should make it follow the majority for better UX and rather implement "re-instantiation" in aap-lv2. It seems what JUCE LV2 support does too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant