Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canon_gmail.c but, like, for everyone #736

Open
jesopo opened this issue Dec 6, 2020 · 3 comments · May be fixed by #761
Open

canon_gmail.c but, like, for everyone #736

jesopo opened this issue Dec 6, 2020 · 3 comments · May be fixed by #761
Assignees

Comments

@jesopo
Copy link
Member

jesopo commented Dec 6, 2020

  • i think stripping +stuff from all providers is safe
  • have a config file list of domains to strip . from
  • have a config file list of domain aliases (think pm.me -> protonmail.com)
@grawity
Copy link
Contributor

grawity commented Dec 6, 2020

  • i think stripping +stuff from all providers is safe

Probably safe to enable it by default, but I think the same config file should reserve a place for listing domains that are exceptions, mostly out of principle. (Or even for listing domains and their separator characters, like { placewheregrawityworks.com = ":", someqmailsite.net = "-", weird.tld = null /* don't strip anything */ }.)

Make sure the code doesn't give weird results when the separator is the 1st character (like +fred@example.com). Gmail wouldn't have allowed that, but you know there will be some smartass running their own Postfix where it's completely legal. As is +@example.com, apparently.

@jesopo
Copy link
Member Author

jesopo commented Dec 6, 2020

handling +subaddress by default, paired with LISTOWNMAIL returning canonicalised matches, presents a problem when we hit a provider that doesn't handle +subaddress specially and there's two distinct humans with accounts that match the lefthand-side of the +. this seems like a bit of a show-stopped for "by default", as far as user privacy is concerned.

@jesopo
Copy link
Member Author

jesopo commented Dec 6, 2020

perhaps extending +subaddress stripping for canonicalisation should be paired with changing LISTOWNMAIL back to not considering addresses that only match once canonicalised

@ilbelkyr ilbelkyr self-assigned this Feb 12, 2021
@ilbelkyr ilbelkyr linked a pull request Feb 14, 2021 that will close this issue
@ilbelkyr ilbelkyr linked a pull request Feb 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@grawity @ilbelkyr @jesopo and others