Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of shadow acne #34

Open
athas opened this issue Apr 21, 2020 · 1 comment
Open

Get rid of shadow acne #34

athas opened this issue Apr 21, 2020 · 1 comment

Comments

@athas
Copy link
Owner

athas commented Apr 21, 2020

The black dots marring the single-precision implementations are because of numerical error, which causes the hit to be computed as within the sphere, not on top of it. An easy fix is to move the collision point a tiny amount in the direction of the hit normal. I've verified that this works, so now I guess I have to change it in every implementation...
@athas
Copy link
Owner Author

athas commented Jan 11, 2022

A solution is here, but was added only to the Futhark implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@athas