Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the "ATDL parsing into Java" from the UI #34

Open
philipwhiuk opened this issue Jun 8, 2022 · 4 comments
Open

Split the "ATDL parsing into Java" from the UI #34

philipwhiuk opened this issue Jun 8, 2022 · 4 comments

Comments

@philipwhiuk
Copy link

philipwhiuk commented Jun 8, 2022

The library would be more useful to projects if the ATDL parsing into Java classes was split from the UI code and the project available via Maven repositories:

My proposal would be:

1 . Split the code into Maven submodes:

  • atdl-core - the ATDL parsing core
  • atdl-ui - the UI abstraction layer
  • atdl-swt - just the SWT specific code
  • atdl-swing - just the Swing specific code
  • atdl-all - the drop-in replacement for the current project.
  1. Move the unmarshalling logic from AbstractAtdl4jCompositePanel#parseFixatdlFile to AtdlParser in atdl-core

  2. Publish to Maven Central

I'm happy to prepare some PRs to work toward this if it'd be upstreamed.

@philipwhiuk philipwhiuk changed the title Split ATDL parsing into Java from UI Split the "ATDL parsing into Java" from the UI Jun 8, 2022
@johnnyshields
Copy link
Member

@philipwhiuk I'm looking for a new maintainer for this repo if you're interested.

I'd be fine with this refactor, however, let's keep it all within this same Github repo (i.e. rather than making 5 different Github repos.)

@philipwhiuk
Copy link
Author

Yep, no need to have multiple repositories. And yes I think I should have time to help maintain it.

@johnnyshields
Copy link
Member

Ok, great! Please raise the PR first.

@johnnyshields
Copy link
Member

johnnyshields commented Aug 9, 2022

Also, please use the following package names if possible:

atdl4j-core  - the ATDL parsing core
atdl4j-ui    - the UI abstraction layer
atdl4j-swt   - just the SWT specific code
atdl4j-swing - just the Swing specific code
atdl4j       - the drop-in replacement for the current project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants