Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gutters issue #243

Open
dekisha opened this issue Sep 13, 2017 · 3 comments
Open

Fixed gutters issue #243

dekisha opened this issue Sep 13, 2017 · 3 comments

Comments

@dekisha
Copy link

dekisha commented Sep 13, 2017

When gutter is set as fixed, gutters are added as paddings instead of margins.

So when you set your last column as last with @include float-span(4, last); for example last column loses its gutter but occupies whole available space.

I described this issue in detail on stackoverflow:

https://stackoverflow.com/questions/46179004/singularity-grid-fixed-gutters-issue

@cameronprince
Copy link

@dekisha, did you ever find a solution to this problem? Fixed gutters isn't really viable as it is now because the sizing is inconsistent.

@dekisha
Copy link
Author

dekisha commented Jul 6, 2018

@cameronbprince no, I haven't find a solution to my issue. I understand that sizing is inconsistent, but design requirements were to always have fixed gutter of 20px. IMO there shouldn't be an option to use fixed gutters in singularity if it's impossible to align left and right edge with container.

Nevertheless I am using flexbox for layout now, so this is issue is no longer that much relevant to me. But I would really want to know if this is a bug or I am doing something wrong?

Stackoverflow question hasn't been answered as well as you can notice.

@scottkellum
Copy link
Member

Thanks for the bug report and yes it sounds like it’s either a bug with the code or the documentation.

However Singularity is no longer being maintained and we recommend using CSS grid or flexbox instead as they do many of the same things more simply and efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants