Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Dec 2020 - Jan 2021 #139

Open
tima101 opened this issue Dec 8, 2020 · 0 comments
Open

Updates Dec 2020 - Jan 2021 #139

tima101 opened this issue Dec 8, 2020 · 0 comments
Assignees
Labels
Ready to test - Async Issue is implemented and ready for testing. PR is merged.

Comments

@tima101
Copy link
Member

tima101 commented Dec 8, 2020

  • update in the book (done)
        domain: dev ? 'localhost' : process.env.COOKIE_DOMAIN,
    
  • CORS issue for uploading image to Post in demo app #135 (saas demo) (done)
  • FE not able to communicate with BE #136 (README as well) (done)
  • move line this.setState({ content: '' }); to clear content from PostForm (done)
  • "yarn": "1.22.5" (done)
  • move viewport meta tag to MyApp from MyDocument (done)
  • socket.io and socket.io-client version 3.0.3 - breaking changes (done)
  • ESLint fixes in codebase (done)
  • ESLint fixes in content (done)
  • update packages (done)
  • Mongoose: setOptions => lean() (done)
  • move open source project to saas folder (done)
  • HOC extensions, not HOCs: MyApp and MyDocument. Actual HOC: withAuth (Chapter 2, done)
  • improve ctx.renderPage explanation (Chapter 2, done)
  • remove api/server/env.ts file (Chapter 3, done)
  • remove old comments from codebase (done)
  • rewrite Jest tests with async/await (Chapter 4, done)
  • comment about membersMinusCreator on the CreateDiscussionForm form (done)
  • isThemeDark for DiscussionListItem and DiscussionList (done)
  • Nprogress for store.currentUser.toggleTheme (done)
  • two new diagrams for session and cookie, logged-out user and logged-in user (done, Chapter 5)
  • clarify why we need in book-1 and book-2: request.credentials for browser-to-server and req.headers.cookie for server-to-server (done, Chapter 5)
  • review Google OAuth API explanation (done, Chapter 5)
  • improvements to App HOC, withAuth HOC, YourSettings page pass ctx.req to getUserApiMethod as an argument directly (done, Chapter 5 and other chapters)
  • upgrade typescript to 4.1.3 (done)
  • review and improve withAuth HOC explanation (done, Chapter 5)
  • review Introduction chapter (done)

Done with all planned updates.

@tima101 tima101 self-assigned this Dec 8, 2020
@tima101 tima101 added the Assigned - Async Issue is assigned to at least one person. PR is assigned to at least one person. label Dec 8, 2020
@async-labs async-labs locked as resolved and limited conversation to collaborators Dec 8, 2020
@tima101 tima101 pinned this issue Dec 8, 2020
@tima101 tima101 added Uphill - Async and removed Assigned - Async Issue is assigned to at least one person. PR is assigned to at least one person. labels Dec 15, 2020
@tima101 tima101 added Downhill - Async Issue is being actively implemented, interruptions are discouraged. PR is under review. and removed Uphill - Async labels Dec 29, 2020
@tima101 tima101 reopened this Jan 15, 2021
@tima101 tima101 changed the title Upcoming updates to the book and the main project Updates Dec 2020 - Jan 2021 Feb 10, 2021
@tima101 tima101 added Ready to test - Async Issue is implemented and ready for testing. PR is merged. and removed Downhill - Async Issue is being actively implemented, interruptions are discouraged. PR is under review. labels Feb 10, 2021
@tima101 tima101 unpinned this issue Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready to test - Async Issue is implemented and ready for testing. PR is merged.
Projects
None yet
Development

No branches or pull requests

1 participant