Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformer example and texar-pytorch/bin/utils should be improved #180

Open
gpengzhi opened this issue Aug 30, 2019 · 0 comments
Open

transformer example and texar-pytorch/bin/utils should be improved #180

gpengzhi opened this issue Aug 30, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request topic: examples Issue about examples

Comments

@gpengzhi
Copy link
Collaborator

gpengzhi commented Aug 30, 2019

In texar-pytorch/bin/utils, sentencepiece is a package instead of a tokenization method, so sentencepiece encoding is not a very accurate way to describe the tokenization method. sentencepiece includes two sub-word tokenization methods: byte-pair-encoding (BPE)[Sennrich et al.] and unigram language model [Kudo.].

There is no Word Piece Model (WPM) pipeline in sentencepiece, and the code we used

spm_train --input=train.src,train.tgt --vocab_size 32000 --model_prefix=wpm-codes

is actually using unigram language model. Here, Unigram is the default method.

transformer example need to be updated accordingly.

@gpengzhi gpengzhi added enhancement New feature or request topic: examples Issue about examples labels Aug 30, 2019
@gpengzhi gpengzhi self-assigned this Aug 31, 2019
@gpengzhi gpengzhi assigned swapnull7 and unassigned gpengzhi Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: examples Issue about examples
Projects
None yet
Development

No branches or pull requests

2 participants