Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify inputs to wavelength calibration 1d, allow frequency inputs in addition to wavelengths #181

Open
cshanahan1 opened this issue Jun 9, 2023 · 0 comments

Comments

@cshanahan1
Copy link
Contributor

Currently there are a variety of allowed input types for matched pixel and wavelengths - both can be an input quantity array, an input Q table with specific column names, a combination of table and column, or two separate one-column tables. I think this is a bit confusing, especially because it becomes the case where some parameters are only used if others are set, and we should allow only one input format. The decision of which one to allow (two arrays vs. table) should be standard across the package as well. I think that requiring two quantity arrays makes the most sense, since this avoids checking for specific column names and that the data type matches these column names.

Additionally, there are references in the code to matched pixel+frequency being allowed for the fit, but there are checks for the presence of specifically a 'wavelength' column, so this simplification of inputs should address this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant