Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reprojection changes floating point precision #353

Open
NimSed opened this issue Mar 16, 2023 · 2 comments
Open

Reprojection changes floating point precision #353

NimSed opened this issue Mar 16, 2023 · 2 comments

Comments

@NimSed
Copy link

NimSed commented Mar 16, 2023

Hi there.

This very line:

array = np.asarray(array, dtype=float)

changes an input array with dtype=float32 to float64.

Could we replace it with a mere check (for all floating point types) instead, and raise an error in case the input isn't a float?

@NimSed
Copy link
Author

NimSed commented Mar 16, 2023

I just created this PR: #354
Please feel free to scrap it if it doesn't make sense.

@NimSed
Copy link
Author

NimSed commented Mar 16, 2023

Update: Of course, the PR fails for many of the dtypes in this test 🤕
But how did it pass the test before, since ALL_DTYPES seems to contain, all dtypes, including i, u (here) 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant