Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annulus region masks restricted to mode='center' #352

Open
larrybradley opened this issue May 12, 2021 · 0 comments
Open

Annulus region masks restricted to mode='center' #352

larrybradley opened this issue May 12, 2021 · 0 comments

Comments

@larrybradley
Copy link
Member

larrybradley commented May 12, 2021

Currently annulus regions (e.g. CircleAnnulusPixelRegion) are implemented as Compound regions and Compound region masks are restricted to use only mode='center' (see https://github.com/astropy/regions/blob/main/regions/core/compound.py#L68). This makes sense for generic user-defined generic regions, but not for the provided CircleAnnulusPixelRegion, EllipseAnnulusPixelRegion, and RectangleAnnulusPixelRegion objects for which the other modes are well-defined. For example, it's not currently possible to perform "exact" aperture photometry with any of these provided annulus region objects.

I thought that originally the annulus region masks could use other overlap modes (e.g., photutils provides this), so I suspect that this behavior changed at some point when the annulus regions were refactored. Perhaps it was unintended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant