Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visual should validate keys/values #324

Open
astrofrog opened this issue Jul 23, 2020 · 2 comments
Open

visual should validate keys/values #324

astrofrog opened this issue Jul 23, 2020 · 2 comments
Labels
feature-request metadata

Comments

@astrofrog
Copy link
Member

Currently, the .visual property is just a free-form dictionary which allows things such as:

region.visual['banana'] = 'apple'

We should make sure we validate the keys/values for this dictionary and make it easy for users to find out the keys that can be set (perhaps by setting some sensible defaults)
@astrofrog
Copy link
Member Author

Ideally visual should maybe even be a Visual class with property-based access (we could keep dict-like access for a while then deprecate it)

@keflavich
Copy link
Contributor

👍 but I want maximal easter eggs in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request metadata
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@keflavich @astrofrog @larrybradley