Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge spectral regions #228

Open
keflavich opened this issue Dec 4, 2018 · 2 comments
Open

Merge spectral regions #228

keflavich opened this issue Dec 4, 2018 · 2 comments
Assignees
Labels
io.crtf CASA region file format question

Comments

@keflavich
Copy link
Contributor

Spectral-regions have been defined in specutils:
astropy/specutils#289

They should be included in regions eventually, especially since CRTF now supports spectral region serialization.

@cdeil cdeil added this to the astropy-core-pr milestone May 16, 2019
@cdeil cdeil added io.crtf CASA region file format question labels May 16, 2019
@cdeil
Copy link
Member

cdeil commented May 16, 2019

@keflavich - What does including spectral regions here mean?

Is it just adding something to the I/O and specutils becomes an optional dependency?

Or do you mean changes to the data classes and possibly backwards-incompat breaks?

@keflavich
Copy link
Contributor Author

It means adding things; I don't see any reason there should be any backward-incompatible breaks.

I'm uncertain whether specutils would become a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io.crtf CASA region file format question
Projects
None yet
Development

No branches or pull requests

2 participants