Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #44

Open
astrofrog opened this issue Oct 30, 2014 · 2 comments
Open

Improve test coverage #44

astrofrog opened this issue Oct 30, 2014 · 2 comments
Labels
enhancement tests
Milestone
2.1

Comments

@astrofrog
Copy link
Member

The current test coverage is around 50%, so we should work on improving that:

https://coveralls.io/r/astropy/pyregion

Of course, we shouldn't try and improve coverage of e.g. kapteyn_celetial.py since this is an external package (and see #43 for a suggestion of removing it in favor of using astropy.coordinates).
sargas added a commit to sargas/pyregion that referenced this issue Nov 16, 2014
@sargas
Obliterate Kapteyn code. Leave no survivors.
cf491a2 
Add docs and tests to the Kapteyn-less methods
Addresses astropy#43 and astropy#44, fixes astropy#35
sargas added a commit to sargas/pyregion that referenced this issue Nov 16, 2014
@sargas
Obliterate Kapteyn code. Leave no survivors.
96328e4 
Add docs and tests to the Kapteyn-less methods
Addresses astropy#43 and astropy#44, fixes astropy#35
sargas added a commit to sargas/pyregion that referenced this issue Mar 30, 2016
@sargas
Obliterate Kapteyn code. Leave no survivors.
4029a99 
Add docs and tests to the Kapteyn-less methods
Addresses astropy#43 and astropy#44, fixes astropy#35
@cdeil cdeil modified the milestones: wishlist, v1.3 Aug 1, 2016
@cdeil
Copy link
Member

cdeil commented Aug 4, 2016

Current test coverage is at 63%:
https://coveralls.io/github/astropy/pyregion

Especially pyregion/mpl_helper.py is at 0%, if someone could add even one test that does MPL plotting, that would be very valuable to have.

Other files we should focus on are pyregion/region_to_filter.py and pyregion/core.py where it's easy to test many lines with just a few high-level test that make sure key functionality is working and keeps working.

I'm assigning this to v1.3.

@cdeil cdeil modified the milestones: 2.0, v1.3 Aug 4, 2016
sargas added a commit to sargas/pyregion that referenced this issue Aug 8, 2016
@sargas
Obliterate Kapteyn code. Leave no survivors.
b149a2d 
Add docs and tests to the Kapteyn-less methods
Addresses astropy#43 and astropy#44, fixes astropy#35
@sargas sargas mentioned this issue Aug 11, 2016
Closed
sargas added a commit to sargas/pyregion that referenced this issue Aug 11, 2016
@sargas
Obliterate Kapteyn code. Leave no survivors.
1b87998 
Add docs and tests to the Kapteyn-less methods
Addresses astropy#43 and astropy#44, fixes astropy#35
Add Changelog entries
sargas added a commit to sargas/pyregion that referenced this issue Aug 11, 2016
@sargas
Obliterate Kapteyn code. Leave no survivors.
ac70931 
Add docs and tests to the Kapteyn-less methods
Addresses astropy#43 and astropy#44, fixes astropy#35
Add Changelog entries
@cdeil cdeil mentioned this issue Apr 17, 2017
Merged
@cdeil
Copy link
Member

cdeil commented Apr 17, 2017

@astropy/pyregion-maintainers - We need more high-level tests for pyregion to increase code coverage.

Recently @keflavich has found two serious bugs (#109, #110) that would have been caught by any test exercising the code.

Ideally someone would spend an afternoon to add tests, and then cut a new release for pyregion. Someone interested?

@cdeil cdeil modified the milestones: 2.0, 2.1 Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement tests
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@astrofrog @cdeil