Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jplhorizons remove deprecated columns in the code #2913

Open
ysBach opened this issue Jan 2, 2024 · 2 comments
Open

jplhorizons remove deprecated columns in the code #2913

ysBach opened this issue Jan 2, 2024 · 2 comments

Comments

@ysBach
Copy link

ysBach commented Jan 2, 2024

There are a few deprecated columns that are no longer being queried, but remaining in the __init__.py:

'SunSub-LAT': ('PDSunLat', 'deg'),
'Ob-lon': ('PDObsLon', 'deg'), # deprecated
'Ob-lat': ('PDObsLat', 'deg'), # deprecated
'Sl-lon': ('PDSunLon', 'deg'), # deprecated
'Sl-lat': ('PDSunLat', 'deg'), # deprecated
'Obsrv-lon': ('PDObsLon', 'deg'), # deprecated
'Obsrv-lat': ('PDObsLat', 'deg'), # deprecated
'Solar-lon': ('PDSunLon', 'deg'), # deprecated
'Solar-lat': ('PDSunLat', 'deg'), # deprecated
'SN.ang': ('SubSol_ang', 'deg'),

I think it is safe to remove those lines because the HORIZONS no longer returns such columns...?

@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2024

I suppose these are not required but are still listed to ensure old code using them don't yet start failing, but @mkelley can correct me and point out if it's time for a cleanup.

@mkelley
Copy link
Contributor

mkelley commented Jan 11, 2024

Yeah, they should get removed. I think the only drawback is that older cached files would fail. When was the change made? It might also require an update of the offline test files, depending on when those files where generated and when Horizons changed its output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants