Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete list of functions that lose units #10845

Closed
astrojuanlu opened this issue Oct 13, 2020 · 2 comments · Fixed by #10848
Closed

Complete list of functions that lose units #10845

astrojuanlu opened this issue Oct 13, 2020 · 2 comments · Fixed by #10848
Labels
Docs Effort-low good first issue Issues that are well-suited for new contributors Hacktoberfest Hacktoberfest annual event Package-novice units

Comments

@astrojuanlu
Copy link
Member

astrojuanlu commented Oct 13, 2020

you are right that we should add [np.full] to the known issues. One similarly cannot do np.zeros, np.ones, and np.empty.

Originally posted by @mhvk in #10836 (comment)

The list in question: https://docs.astropy.org/en/latest/known_issues.html#quantities-lose-their-units-with-some-operations

@astrojuanlu astrojuanlu added Docs good first issue Issues that are well-suited for new contributors Hacktoberfest Hacktoberfest annual event units labels Oct 13, 2020
@rpsfonseca
Copy link
Contributor

rpsfonseca commented Oct 13, 2020

I'd like to work on this. I understand that we must add np.full to the list mentioned here. But by saying

One similarly cannot do np.zeros, np.ones, and np.empty

means those should be also added to the list?

@pllim
Copy link
Member

pllim commented Oct 13, 2020

Yes. Thank you, @rpsfonseca !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Effort-low good first issue Issues that are well-suited for new contributors Hacktoberfest Hacktoberfest annual event Package-novice units
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants