Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "order" to "scheme" #95

Open
cdeil opened this issue Jun 26, 2018 · 2 comments
Open

Rename "order" to "scheme" #95

cdeil opened this issue Jun 26, 2018 · 2 comments
Assignees

Comments

@cdeil
Copy link
Member

cdeil commented Jun 26, 2018

Currently we have order : { ‘nested’ | ‘ring’ }.

In HEALPix, "order" is also often used for k = log2(nside), so IMO this is confusing and should be changed.

I propose to replace by "scheme".

Using "ordering" which is used in FITS serialisation might be an alternative, but IMO "scheme" is better, leaving no room for confusion.

I'm happy to make a PR to adapt the few affiliated packages using this already, but given that this is alpha software, I'd suggest to just do this change and ship it with v0.3 without deprecation / supporting both for a period of time.

@astrofrog and all - thoughts?

@cdeil cdeil added this to the 0.3 milestone Jun 26, 2018
@cdeil cdeil self-assigned this Jun 26, 2018
@lpsinger
Copy link
Contributor

I agree. Thanks!

@astrofrog
Copy link
Member

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants