Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining healpy compatibility functions #23

Open
4 of 5 tasks
astrofrog opened this issue Sep 17, 2017 · 4 comments
Open
4 of 5 tasks

Implement remaining healpy compatibility functions #23

astrofrog opened this issue Sep 17, 2017 · 4 comments

Comments

@astrofrog
Copy link
Member

astrofrog commented Sep 17, 2017

We can still add compatibility functions (just thin wrappers) for the following:

  • healpy.boundaries (using healpix_boundaries_lonlat)
  • healpy.nest2ring (using nested_to_ring)
  • healpy.ring2nest (using ring_to_nested)
  • healpy.reorder (using nested_to_ring or ring_to_nested)
  • get_interp_val (using interpolate_bilinear_lonlat)
@astrofrog
Copy link
Member Author

I don't think we want to implement query_disk since we use a different algorithm that seems to give more reliable results so no point trying to reproduce the healpy algorithm.

@astrofrog astrofrog modified the milestones: 0.1, 0.2 Oct 2, 2017
@cdeil cdeil modified the milestones: 0.2, 0.3 Oct 17, 2017
@cdeil
Copy link
Member

cdeil commented Jun 25, 2018

Here's what we have now:
http://astropy-healpix.readthedocs.io/en/latest/api.html#module-astropy_healpix.healpy

As mentioned, reorder is still missing:
http://healpy.readthedocs.io/en/latest/generated/healpy.pixelfunc.reorder.html

@astrofrog - Do you think we should add it now, or wait for users to request it?
@lpsinger - Do you use it? Or are there others that are missing that we should add before cutting a new release?

@astrofrog
Copy link
Member Author

astrofrog commented Jun 25, 2018

@cdeil - reorder should be easy enough to implement by using nested_to_ring and ring_to_nested. But no rush if no one is asking for it.

@lpsinger
Copy link
Contributor

Do you use it?

Yes I do.

Or are there others that are missing that we should add before cutting a new release?

Not sure at the moment; it would take me an hour or two to update astropy-healpix branches of my code and test them.

@cdeil cdeil modified the milestones: 0.3, Future Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants