Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated astropy helper functions. #553

Open
wtgee opened this issue Jun 1, 2023 · 1 comment · May be fixed by #554
Open

Remove deprecated astropy helper functions. #553

wtgee opened this issue Jun 1, 2023 · 1 comment · May be fixed by #554

Comments

@wtgee
Copy link
Collaborator

wtgee commented Jun 1, 2023

Need to remove this old function. pytest now warns by default but that seems different from an exception being raised. Not sure we really need exception raised since the warning is shown at end of test run.

          Failure is from astropy removing old code, which you should definitely fix, but unrelated to this PR.

Originally posted by @pllim in #552 (comment)

wtgee added a commit to wtgee/astroplan that referenced this issue Jun 1, 2023
@wtgee wtgee linked a pull request Jun 1, 2023 that will close this issue
@pllim
Copy link
Member

pllim commented Jun 1, 2023

No, I think it is a real error, since I actually removed the deprecated stuff from astropy today. It had been deprecated for a long time though, so maybe your CI was ignoring the deprecation before? 😅

ImportError: cannot import name 'enable_deprecations_as_exceptions' from 'astropy.tests.helper'

See astropy/astropy#14670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants