Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELM] Not possible to set custom Ingress annotations without enabling authSidecar #1353

Open
CarpathianUA opened this issue Jan 31, 2022 · 3 comments

Comments

@CarpathianUA
Copy link

CarpathianUA commented Jan 31, 2022

{{- if .Values.global.authSidecar.enabled }}

Why?

Thanks in advance!

@AmFlint
Copy link
Contributor

AmFlint commented Feb 9, 2022

I believe these extra annotations were used to configure Auth sidecar.

I guess we might want to also allow users to create extra annotations without Auth sidecar.

I will add an internal issue and implement a fix with the team 😁

@rbankston
Copy link
Contributor

It is possible to add arbitrary Ingress annotations via https://github.com/astronomer/astronomer/blob/master/charts/nginx/values.yaml#L43-L44

@CarpathianUA
Copy link
Author

@rbankston
This will be applied only to the Nginx Service object, and is not related to the Ingress object.

{{ range $key, $value := .Values.ingressAnnotations }}

Ingress template is defined here and there is no way to provide annotations without authSidecar enabled. So usage of non-bundled Ingress Controller is not possible - you can't specify needed annotation for Ingress class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants