Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssa code #54

Open
eager7 opened this issue Aug 13, 2021 · 3 comments
Open

ssa code #54

eager7 opened this issue Aug 13, 2021 · 3 comments
Assignees
Labels

Comments

@eager7
Copy link

eager7 commented Aug 13, 2021

when i read this line:

Dialogue: 0,0:00:36.38,0:00:38.84,DX,NTP,0,0,0,!Effect,Even solo players need to\Ntake this more seriously{\fscx300}-{\r}

the result is nil. I read code :
https://github.com/asticode/go-astisub/blob/master/ssa.go#L1068

and find this func not handle text before {\fscx300}.
is this a feature or bug ?

@asticode
Copy link
Owner

This is definitely a bug 😫

I've pushed a fix on master as well as in the v0.17.0 tag.

Let me know whether this is better.

@eager7
Copy link
Author

eager7 commented Aug 14, 2021

can i join this project?

@asticode asticode self-assigned this Aug 14, 2021
@asticode asticode added the bug label Aug 14, 2021
@asticode
Copy link
Owner

What do you mean by join the project?

You can submit PRs if you feel like contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants