Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srtTimeBoundariesSeparator will lead to incorrect results #51

Open
eager7 opened this issue Jul 21, 2021 · 1 comment
Open

srtTimeBoundariesSeparator will lead to incorrect results #51

eager7 opened this issue Jul 21, 2021 · 1 comment
Assignees

Comments

@eager7
Copy link

eager7 commented Jul 21, 2021

const (
srtTimeBoundariesSeparator = " --> "
)

when the srt content is like:

1
00:08:29,079 -->00:08:30,119
hello

because there lose a space, this line will not be indefiy, output string will be nothing.

i hope return a error for this

@asticode
Copy link
Owner

As the .srt you're mentionning is not valid, the only thing this lib could do is return an error. However the way things are done, it's not trivial to do it while changing the least amount of code. I'll add it to this project's todo but won't have time to work on it anytime soon

@asticode asticode self-assigned this Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants