Permit multiple attempts to load PostgreSQL CDR module. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cherry-pick-to: 21 |
github-actions
bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
The UserNote in the commit message isn’t necessary |
chrsmj
force-pushed
the
prevent-crash-on-cli-when-repeating-loads-of-cdr-pgsql
branch
from
df183e7
to
fdd330d
Compare
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-failed
labels
seanbright
suggested changes
May 20, 2024
chrsmj
force-pushed
the
prevent-crash-on-cli-when-repeating-loads-of-cdr-pgsql
branch
from
fdd330d
to
1397494
Compare
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
mbradeen
reviewed
May 20, 2024
seanbright
reviewed
May 20, 2024
chrsmj
force-pushed
the
prevent-crash-on-cli-when-repeating-loads-of-cdr-pgsql
branch
from
1397494
to
0941837
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-tests-passed
pr-submit-testing-in-progress
labels
mbradeen
approved these changes
May 20, 2024
chrsmj
force-pushed
the
prevent-crash-on-cli-when-repeating-loads-of-cdr-pgsql
branch
from
0941837
to
4bbfb9d
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-tests-failed
pr-submit-testing-in-progress
labels
jcolp
requested changes
May 22, 2024
Missing or corrupt cdr_pgsql.conf configuration file can cause the second attempt to load the PostgreSQL CDR module to crash Asterisk via the Command Line Interface because a null CLI command is registered on the first failed attempt to load the module. Resolves: asterisk#736
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-passed
labels
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
jcolp
approved these changes
May 28, 2024
github-actions
bot
added
cherry-pick-testing-in-progress
asterisk-org-access-app
bot
merged commit f789b77
into
asterisk:master
68 of 79 checks passed
|
Successfully merged to branch master and cherry-picked to ["21","20","18"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing or corrupt cdr_pgsql.conf configuration file can cause the second attempt to load the PostgreSQL CDR module to crash Asterisk via the Command Line Interface because a null CLI command is registered on the first failed attempt to load the module.
Resolves: #736