[bug]: Watchers for call parking being deactivated during reload

[lukeescude]

Severity

Major

Versions

20.6.0

Components/Modules

res_parking

Operating Environment

Debian 12 x64

Frequency of Occurrence

Constant

Issue Description

When performing a reload after the res_parking.conf file has been touched, I notice that BLFs on some phones stop working for a bit - Turns out, Asterisk is deactivating watchers in the middle of a reload of res_parking.

The desired behavior would be for the subscriptions to be kept, if at all possible, so users don't have to wait for the next SUBSCRIBE cycle.

Steps to reproduce: Set up a parking lot configuration, subscribe a phone or two to some of the lots, then perform a core reload after touching res_parking.

Relevant log output

Snippet from the CLI when a core reload occurs:

    -- Remove parkedcalls-t207/49610/-1, registrar=res_parking/park-0c2343c0-1275-42eb-b3bf-847e0f7be567; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/701/1, registrar=res_parking/park-9b6e40cd-2549-4b9a-99bb-9f4fed979bc4; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/701/-1, registrar=res_parking/park-9b6e40cd-2549-4b9a-99bb-9f4fed979bc4; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/702/1, registrar=res_parking/park-9b6e40cd-2549-4b9a-99bb-9f4fed979bc4; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/702/-1, registrar=res_parking/park-9b6e40cd-2549-4b9a-99bb-9f4fed979bc4; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/703/1, registrar=res_parking/park-9b6e40cd-2549-4b9a-99bb-9f4fed979bc4; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/703/-1, registrar=res_parking/park-9b6e40cd-2549-4b9a-99bb-9f4fed979bc4; con=<nil>((nil)); con->root=(nil)
  == Watcher for hint 701 deactivated
  == Watcher for hint 702 deactivated
    -- Remove parkedcalls-t207/56912/1, registrar=res_parking/park-aee7cfa3-d4b9-45ea-a113-be454d2a0cfd; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/56912/-1, registrar=res_parking/park-aee7cfa3-d4b9-45ea-a113-be454d2a0cfd; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/56913/1, registrar=res_parking/park-aee7cfa3-d4b9-45ea-a113-be454d2a0cfd; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/56913/-1, registrar=res_parking/park-aee7cfa3-d4b9-45ea-a113-be454d2a0cfd; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/19355/1, registrar=res_parking/park-6a0ba9ed-2c96-4389-bf73-0e64af497957; con=<nil>((nil)); con->root=(nil)
    -- Remove parkedcalls-t207/19355/-1, registrar=res_parking/park-6a0ba9ed-2c96-4389-bf73-0e64af497957; con=<nil>((nil)); con->root=(nil)

Asterisk Issue Guidelines

• Yes, I have read the Asterisk Issue Guidelines

[jcolp]

Can you please also attach a core debug of the operation occurring, and the hints?

[lukeescude]

Hint:
701@parkedcalls-t207: park:701@parkedcalls State:Idle Presence:not_set Watchers 1

But it's strange, the CLI doesn't show that error when I've got debug set to 5 for the core.

I do see a bunch of these, which may be inconsequential:
[Feb 27 21:24:05] DEBUG[35886]: pbx.c:8224 __ast_context_destroy: Couldn't delete ctx vm-4b3bf86c-1c5a-492c-a793-ebdce8c65971-check/pbx_config; refc=1; tmp.root=0x7fef75f6dd70 [Feb 27 21:24:05] DEBUG[35886]: pbx.c:8113 __ast_context_destroy: Investigate ctx vm-4ad689b2-f509-4d77-9aab-9919f4c885ce-check pbx_config

[jcolp]

For others who may investigate, this also requires the "parkinghints" option set to "yes". The default is "no".