-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of the new LinkedIn API version format #781
Comments
Thanks for raising this issue. As you have a working integration, would you be willing to submit a PR to do the necessary changes? |
Hello, ok, sure, I will submit a new PR. |
Hi all, FYI, I submitted a ticket to Linked In about this because while I was able to move some of my The response stated that the new API version format for now is only relevant for LinkedIn Marketing Solutions(LMS) API calls not OAuth logins etc. I double checked with them as the email I got did seem to suggest my app would need changing but they were clear that my app which uses AspNet.Security.OAuth.LinkedIn would not need to change and that we can continue with the I've pasted the relevant bits from my ticket with them below. Hope this helps.
Then when questioned about why I got the email:
|
UPDATE I was just going to add the Sign in with LinkedIn product that the However, I could not find it as it seems that this has now been deprecated https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin We now have to "Sign In with LinkedIn using OpenID Connect" https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin-v2 Does this mean we need to migrate and upgrade existing apps? And does the Has anyone been through this new process yet that could give me some pointers or have any information that could help? @martincostello and @arlek777 is this something either of you have seen yet? I'll carry on doing some digging but wanted to mention it here. Maybe I should have opened a new issue? |
Sorry, no, this isn't something I've been looking into. |
No, it doesn't: the authorization and token endpoints used by the We'll of course accept a PR that updates the provider to support the V2 API 😃 Alternatively, the OpenIddict client has a built-in LinkedIn integration that uses the V2/OIDC service (more info here, if you're not familiar with OpenIddict and its web providers: https://kevinchalet.com/2022/12/16/getting-started-with-the-openiddict-web-providers/). |
Thanks @kevinchalet I'm really not familiar with OpenIddict at all, I would much prefer to carry on using this, so let me have a stab at adding a PR to support this. Any preferred way of me handling V1 (which still seems to work) and V2/OpenID Connect as in any prior art where this has been done before in the code. I'll give it a go anyway. Oh and for what it's worth I've replied to my original ticket about the endpoints that I made a while ago mentioning this to see what LinkedIn have to say/offer. |
To simplify things, we'll probably want to just use the V2 service, even if it's technically breaking (you need to enable the V2 service via the LinkedIn portal and the claims are not the same). I don't think it's worth trying to support both versions 😃 |
Provider name
AspNet.Security.OAuth.LinkedIn
Expected behavior
The LinkedIn provider is updated to support LinkedIn's new API version format that is introduced in June 2022. The old version (which is used now by the provider) will be shut down on 30 June 2023. Here is an official page: https://learn.microsoft.com/en-us/linkedin/marketing/versioning?trk=eml-mktg-cust-202305-global-api-migrations-june&src=e-drip&mcid=7057115242148806657&view=li-lms-2023-04
Actual behavior
The LinkedIn provided uses the old API version (or I haven't found a new one in the repository).
Additional information
Accordingly to the documentation, it shouldn't take more than 15 minutes. I can also update it manually in my project by overriding Defatuls but it would be great to have a working NuGet package after 30 June 2023.
The text was updated successfully, but these errors were encountered: