Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collission Detection improvements #42

Open
CoreyHendrey opened this issue Nov 27, 2017 · 2 comments
Open

Collission Detection improvements #42

CoreyHendrey opened this issue Nov 27, 2017 · 2 comments

Comments

@CoreyHendrey
Copy link
Contributor

I added walls to the game.

This exposed a problem with our current collision system, though.

First I had to alter the functions slightly to return boundaries correctly, this was a minor change.
The major change, we will have to discuss.

For collision detection, you want to test where the player IS GOING TO BE, not where he currently is. That's my understanding anyway. The way we have it currently, this is impossible without some ugly hacky code.

Does anyone have any ideas about how to implement this nicely?

@ashish2199
Copy link
Owner

@CoreyHendrey which hack are you talking about ?

Also have a look at the dying animation pull request, I added.

@StewartWallace1115
Copy link
Contributor

I submitted a PR. It is an OK solution until we find a better one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants