Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow closing square bracket to be escaped in inline anchor shorthand #3788

Open
mojavelinux opened this issue Oct 23, 2020 · 1 comment · May be fixed by #3792
Open

Allow closing square bracket to be escaped in inline anchor shorthand #3788

mojavelinux opened this issue Oct 23, 2020 · 1 comment · May be fixed by #3792
Assignees
@mojavelinux
Labels
bug compliance
Milestone
v2.x

Comments

@mojavelinux
Copy link
Member

mojavelinux commented Oct 23, 2020 •
edited

It should be possible to escape a closing square bracket in the reftext of an inline anchor defined using shorthand.

Example:

[[id,[reftext\]]]text that follows

While the shorthand is parsed correctly, the backslash remains in the reftext.
@mojavelinux mojavelinux self-assigned this Oct 23, 2020
@mojavelinux mojavelinux added this to the v2.0.x milestone Oct 23, 2020
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Oct 27, 2020
@mojavelinux
resolves asciidoctor#3788 allow closing square bracket in reftext of …
95e7b1e 
…inline anchor shorthand to be escaped
@mojavelinux
Copy link
Member Author

While this seems like logical behavior to support, it's actually a rather large change and deviation from legacy AsciiDoc. I wonder whether this should be in 2.1 instead.

mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Oct 27, 2020
@mojavelinux
resolves asciidoctor#3788 allow closing square bracket in reftext of …
427bd0a 
…inline anchor shorthand to be escaped
@mojavelinux mojavelinux modified the milestones: v2.0.x, v2.x Oct 31, 2020
@graphitefriction graphitefriction linked a pull request Dec 19, 2020 that will close this issue
resolves #3788 allow closing square bracket in reftext of inline anchor shorthand to be escaped #3792
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug compliance
Projects
None yet
Milestone
v2.x
1 participant
@mojavelinux