Extension uses a specific word wrap setting on AsciiDoc files

[jeffrey-chongsathien-oxinst]

When editing an .adoc file, the settings mentioned in the title are ignored by the editor. Is this intended behaviour? If so, why is it desirable?

Ascidoc > Preview: Use Editor Style is set to Yes.

[ggrossetie]

It seems to be working as intended:

Could you please provide details about:

• What you're trying to do
• What happened
• What you expected to happen

[amckibben]

I absolutely could not my global user settings for word wrap to apply to asciidoc files 🤷 Worked flawlessly for any other type of file I typically edit (json, yaml, go, python, markdown, etc.).

I figured there must be something overriding / blocking those settings at the workspace level, but could not find any evidence of that.

Finally I just added word wrap settings specifically for the asciidoc language to my global user settings with a block like the following, and that worked like a charm:

  "[asciidoc]": {
    "editor.wordWrap": "bounded",
    "editor.wordWrapColumn": 100
  }

[ggrossetie]

@amckibben I guess global user settings have a lower precedence than:

asciidoctor-vscode/package.json

Lines 574 to 579 in e190123

	"configurationDefaults": {
	"[asciidoc]": {
	"editor.wordWrap": "on",
	"editor.quickSuggestions": false
	}
	},

The Markdown extension is using more or less the same settings: https://github.com/microsoft/vscode/blob/f88bce8fe6a6d2ccd27cbd64bb26853cd8779afa/extensions/markdown-language-features/package.json#L692-L701

So I'm not really sure why it does not work the same... 🤔

[ggrossetie]

I guess this is more a debate about if we should define a specific wordWrap and, if so, which default value we should use.
Any opinion on this matter @mojavelinux @ahus1? I guess wordWrap: on is a good default value when reading/writing documentation no?

[ggrossetie]

And also a documentation issue to explain how to override it using:

  "[asciidoc]": {
    "editor.wordWrap": "bounded",
    "editor.wordWrapColumn": 100
  }

(as mentioned by Alex)

[mojavelinux]

I'm not entirely sure what the question is. I would expect that the text would soft wrap when it overflows the visible area. Is that the feature being discussed?

[ggrossetie]

Yes that's correct:

  // Controls how lines should wrap.
  //  - off: Lines will never wrap.
  //  - on: Lines will wrap at the viewport width.
  //  - wordWrapColumn: Lines will wrap at `editor.wordWrapColumn`.
  //  - bounded: Lines will wrap at the minimum of viewport and `editor.wordWrapColumn`.
  "editor.wordWrap": "off",

You can control word wrap through the editor.wordWrap setting. By default, editor.wordWrap is off but if you set to it to on, text will wrap on the editor's viewport width.

https://code.visualstudio.com/docs/editor/codebasics#_how-do-i-turn-on-word-wrap

We are using "editor.wordWrap": "on" on AsciiDoc files. So, the text will soft wrap at the viewport width.

[mojavelinux]

We are using "editor.wordWrap": "on" on AsciiDoc files. So, the text will soft wrap at the viewport width.

That seems like a reasonable default to me.

[ahus1]

Same here, it is a reasonable default.

The AsciiDoc plugin for IntelliJ choses a different way: In IntelliJ, there is a global setting for enabling this by file extension. When using the AsciiDoc plugin for IntelliJ for the first time, it show a notification and tries to guide the user to this setting to change it there, as I didn't want to have a plugin-specific setting when there is a global one.