Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support remote includes #731

Open
apupier opened this issue Jun 20, 2023 · 3 comments · May be fixed by #737
Open

Support remote includes #731

apupier opened this issue Jun 20, 2023 · 3 comments · May be fixed by #737
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement

Comments

@apupier
Copy link
Member

apupier commented Jun 20, 2023

Currently remote includes are not resolved (neither in the preview, neither in completion of attributes)

https://docs.asciidoctor.org/asciidoc/latest/directives/include-uri/#reference-include-content-by-uri

example:

include::https://gist.githubusercontent.com/apupier/528a635931932adbdf755303e0116314/raw/f55d188f903ede2a9f3a25c7deeb28046810fe5c/test-remote-attribute.adoc[]

== test

{remote-test}

preview gives:
image
@apupier apupier added ✨ enhancement 💬 discussion Disccussion on new features, projects, etc... labels Jun 20, 2023
@ggrossetie
Copy link
Member

Did you try with :allow-uri-read:?

@apupier
Copy link
Member Author

apupier commented Jun 22, 2023

image

@ggrossetie
Copy link
Member

setting the allow-uri-read attribute securely from the CLI or API

You need to enable this feature by setting allow-uri-read in your settings (or in your .asciidoctorconfig):

{
    "asciidoc.preview.asciidoctorAttributes": {
        "allow-uri-read": "",
    }
}

Having said that, it does not seems to work inside VS code:

image

apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 29, 2023
@apupier
WIP - attempt to support remote includes
cf2c3f5 
from what i understood, placing the allow-uri-read in attributes should
have done the thing but it is not working... to investigate

resolves asciidoctor#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier linked a pull request Jun 29, 2023 that will close this issue
Draft
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 30, 2023
@apupier
WIP - suuport inlay for Attribute value
fbe4e6f 
resolves asciidoctor#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 30, 2023
@apupier
Support remote includes for PDF export
bec66a7 
part of asciidoctor#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 30, 2023
@apupier
Support remote includes for PDF export
a613227 
part of asciidoctor#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Jun 30, 2023
Merged
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jul 4, 2023
@apupier
Support remote includes for PDF export
738174f 
part of asciidoctor#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
ggrossetie pushed a commit that referenced this issue Jul 4, 2023
@apupier
Support remote includes for PDF export (#739)
14ddb3f 
part of #731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/unxhr that referenced this issue Aug 8, 2023
@apupier
Fix to work in VS Code context
6897f06 
it avoids to rely on `process.execPath` which resolves to `code` binary
in VS Code context although it expects the `node` binary

relates to asciidoctor/asciidoctor-vscode#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Aug 8, 2023
Closed
@ggrossetie ggrossetie mentioned this issue Aug 11, 2023
Closed
apupier added a commit to apupier/unxhr that referenced this issue Aug 17, 2023
@apupier
Support usage in Electron-based application
c2e132d 
especially targeting VS Code

fixes ggrossetie#98
relates to asciidoctor/asciidoctor-vscode#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Aug 17, 2023
Draft
apupier added a commit to apupier/unxhr that referenced this issue Aug 17, 2023
@apupier
Support usage in Electron-based application
6f70e9c 
especially targeting VS Code

fixes ggrossetie#98
relates to asciidoctor/asciidoctor-vscode#731

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP - attempt to support remote includes apupier/asciidoctor-vscode
2 participants
@ggrossetie @apupier