Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist: Checkboxes missing when Fontawesome enabled for icons #526

Open
thomas-ferchau opened this issue Feb 7, 2024 · 3 comments
Open

Comments

@thomas-ferchau
Copy link

thomas-ferchau commented Feb 7, 2024

When enabling Fontawesome for icons (:icons: font), checklists do not contain any checkboxes:

checklist-missing-checkboxes

Checkboxes are shown without Fontawesome - but not scaled with the font (see #451):

checklist-default-ok

Workarounds that I use:

Workaround 1: Replace icon class icon-check with far fa-check-square and icon-check-empty with far fa-square in docinfo-footer-revealjs.html:

checklist-workaround1

Workaround 2: Remove bullets and improve spacing in custom CSS (does not look nice for mixed lists, but I do not use those):

checklist-workaround2

Possible fixes:

  • Show checkbox icons: Replace icon class icon-check with far fa-check-square and icon-check-empty with far fa-square in templates/ulist.html.slim and lib/asciidoctor-revealjs/converter.rb.

  • Remove bullets in check lists and fix spacing: Maybe Add missing list styles #451 would solve that.

@thomas-ferchau
Copy link
Author

The example file and workarounds can be found in this repository for reproducing the problem:
https://github.com/thomas-ferchau/asciidoctor-revealjs-checklist-bug

@thomas-ferchau
Copy link
Author

If someone can confirm that the change (replacing the icon classes) would be fine, I could of course create a pull request for that.

@ggrossetie
Copy link
Member

@thomas-ferchau sorry for the late reply but yes you can submit a pull request. As you've mentioned checklists currently do not look great and we should improve it.

Your second proposal is great. You can take a look at: https://docs.asciidoctor.org/asciidoc/latest/lists/checklist/ which is very close to your second proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants