Activating Reveal.js Extensions only for Reveal.js backend

[rahmanusta]

Hello,

In AsciidocFX, I use AsciidoctorJ to construct a certain number of Asciidoctor instances and load all required libraries all at once. I recently discovered that the highlight js numbering extension registers itself even though that the backend is HTML5. I assumed the asciidoctor-* libraries were isolated from each other if they targeted a specific backend. I think the library should not interfere with the other backends. May it be possible to activate Reveal's highlight.js extension only if the backend is reveal.js ?

asciidoctor-reveal.js/lib/asciidoctor-revealjs/highlightjs.rb

Line 6 in 93b3073

class HighlightJsAdapter < Asciidoctor::SyntaxHighlighter::Base

[ggrossetie]

Hey!

It might be possible to conditionally call SyntaxHighlighter.register instead of using:

asciidoctor-reveal.js/lib/asciidoctor-revealjs/highlightjs.rb

Line 7 in 93b3073

register_for 'highlightjs', 'highlight.js'

However, I'm not really sure how/when we should call it since the SyntaxHighlighter registry is a singleton so I don't think you can have more than one instance.

We could potentially use the backend argument in the constructor to delegate or not to the built-in Highlight.js syntax highlighter when the backend is html5 or revealjs:

https://github.com/asciidoctor/asciidoctor/blob/40bc23cbc105d87ce25892d4c1866fad7f9ba01a/lib/asciidoctor/syntax_highlighter.rb#L19

In other words, the highlight.js adapter (from this converter) will still override the built-in highlight.js syntax highlighter in the registry but use the built-in when the backend is not revealjs. What do you think?