Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step-by-step highlight : no auto-scroll in v4.1.0 #463

Open
bcouetil opened this issue Mar 5, 2022 · 4 comments
Open

Step-by-step highlight : no auto-scroll in v4.1.0 #463

bcouetil opened this issue Mar 5, 2022 · 4 comments

Comments

@bcouetil
Copy link

bcouetil commented Mar 5, 2022

Hello 😄

I've not showed up in a while... I'm moving from asciidoctor-reveal 2020 to asciidoctor-reveal 2022 😄 Thank you again for this stack that helps me a lot for my presentations-as-code.

I'm using lastest docker image, so asciidoctor-reveal 4.1.0 / revealjs 3.9.2

I would like to use the step-by-step highlight. It works nice, except that the "auto-scrolling-to-current-lines" does not work.

Is it me ? is it expected ? If not, is there any public asciidoctor example somewhere which can help me figure out why it does not work for me ?

@bcouetil
Copy link
Author

bcouetil commented Mar 6, 2022

Digging more into this, I understand that the auto-scrolling feature was not here in revealjs 3.9.2. So it seems normal.

On a side node, I understand from documentation that, for the step-by-step highlight, the associated plugin must be enabled (which is not by default), and I did not do it, and yet the step-by-step highlight works...

@bcouetil bcouetil changed the title Step-by-step highlight : no auto-scroll ? Step-by-step highlight : no auto-scroll in v4.1.0 Mar 6, 2022
@ggrossetie
Copy link
Member

On a side node, I understand from documentation that, for the step-by-step highlight, the associated plugin must be enabled (which is not by default), and I did not do it, and yet the step-by-step highlight works..

You mean using Asciidoctor reveal.js 5.0.0-rc.1?
If source highlighting is enabled then this feature will be available. You don't need to explicitly enable the highlight plugin from reveal.js since Asciidoctor does provide source highlighting using the attribute :source-highlighter:.

@bcouetil
Copy link
Author

bcouetil commented Mar 6, 2022

This is with asciidoctor-reveal 4.1.0, but I understand why it's working by default, make sense !

Thanks

@bcouetil bcouetil closed this as completed Mar 6, 2022
@ggrossetie
Copy link
Member

We should probably mention that on this page: https://docs.asciidoctor.org/reveal.js-converter/latest/converter/syntax/syntax-highlighting/ which features from reveal.js are supported (when :source-highlighter is defined) and which are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants