You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'll give a counter example that questions the fix provided for #353 (comment)
= Grid Wrapping Tests
:imagesdir: images/
// reveal.js config
:revealjs_hash: true
:revealjs_center: false
:revealjs_height: 1080
:revealjs_width: 1920
[.columns.wrap]
== Shouldn't Wrap But Does
[.column]
* Things here should not wrap
* But they do, thanks to flex-basis: auto;
[.column]
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
[.column]
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
The expected behavior for me is do not wrap, simply because in my opinion the default behavior should be that when specifying 3 columns, then every column should have one-third of the space and the content auf each column should be adapted, i.e. shrinked or whatever, (as best as possible) to meet that requirement.
The use-case of #353 (comment) was not well suited to demonstrate or show a invalid behavior. I mean, what do you expect, when you say, I want three columns, but provide 2 images that fill over 90% (900 + 900 = 1800) of the screen (1920), leaving only 120 pixel for the first column.
Now, if a columns is "full", for some reason, the flex-basis: auto; forces a wrap and no longer tries to modify the content such that it may fit.
At least for me, this "fix" broke dozens of slides that needed the content to be adapted to fit in a column.
I'm not saying that the old behavior was correct (although it was for me :) ). But I'm asking the question, which behavior is considered valid in this case. Because ther cannot be a solution for both variants.
The text was updated successfully, but these errors were encountered:
I'll give a counter example that questions the fix provided for #353 (comment)
The expected behavior for me is do not wrap, simply because in my opinion the default behavior should be that when specifying 3 columns, then every column should have one-third of the space and the content auf each column should be adapted, i.e. shrinked or whatever, (as best as possible) to meet that requirement.
The use-case of #353 (comment) was not well suited to demonstrate or show a invalid behavior. I mean, what do you expect, when you say, I want three columns, but provide 2 images that fill over 90% (900 + 900 = 1800) of the screen (1920), leaving only 120 pixel for the first column.
Now, if a columns is "full", for some reason, the
flex-basis: auto;
forces a wrap and no longer tries to modify the content such that it may fit.At least for me, this "fix" broke dozens of slides that needed the content to be adapted to fit in a column.
I'm not saying that the old behavior was correct (although it was for me :) ). But I'm asking the question, which behavior is considered valid in this case. Because ther cannot be a solution for both variants.
The text was updated successfully, but these errors were encountered: