Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SVG to image referece in SVG encoded as a data URI (SVG data loader) #2512

Open
scuba1012002 opened this issue Mar 22, 2024 · 1 comment
Assignees
Milestone

Comments

@scuba1012002
Copy link

In the file from the asciidoctor-pdf repo
lib/asciidoctor/pdf/ext/prawn-svg/loaders/data.rb it was advised to remove the
regex
REGEXP = %r(\Adata:image/(?:png|jpe?g);base64(?:;[a-z0-9]+)*,)i
restriction now that prawn-svg supports SVG image references in SVG

Regex from prawn:
REGEXP = %r{\Adata:image/(png|jpeg|svg\+xml);base64(;[a-z0-9]+)*,}i

@scuba1012002 scuba1012002 changed the title Remove asciidoctor SVG image reference Remove asciidoctor SVG image restriction Mar 22, 2024
@mojavelinux mojavelinux changed the title Remove asciidoctor SVG image restriction Add support for SVG to image referece in SVG encoded as a data URI (SVG data loader) Mar 22, 2024
@mojavelinux mojavelinux self-assigned this Mar 22, 2024
@mojavelinux mojavelinux added this to the v2.3.x milestone Mar 22, 2024
@mojavelinux
Copy link
Member

This is related to prawn-svg upgrade in 2.3.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants