Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADOC Theming Table Header Alignment #1094

Open
DanielGrigoras opened this issue Jun 10, 2019 · 6 comments
Open

ADOC Theming Table Header Alignment #1094

DanielGrigoras opened this issue Jun 10, 2019 · 6 comments
Assignees
Milestone

Comments

@DanielGrigoras
Copy link

Is there any way to center the table header text via an ADOC Theme?
Reading the ADOC Theming Guide ( https://github.com/asciidoctor/asciidoctor-pdf/blob/master/docs/theming-guide.adoc#keys-table ) I was disappointed to find out that there's nothing documented on table header text alignment.

@mojavelinux
Copy link
Member

Not via the theme currently. You can do it via the content. See https://asciidoctor.org/docs/user-manual/#cell.

We could certainly provide a fallback value named table_head_align if not set on the cell. Seems like it would be easy to add.

@mojavelinux
Copy link
Member

...except this is the wrong repository. I'll move the issue to asciidoctor-pdf.

@mojavelinux mojavelinux transferred this issue from asciidoctor/asciidoctor Jun 10, 2019
@mojavelinux
Copy link
Member

There we go, now we're in the right place.

@mojavelinux mojavelinux self-assigned this Jun 10, 2019
@mojavelinux mojavelinux added this to the v1.5.0.beta.1 milestone Jun 10, 2019
@DanielGrigoras
Copy link
Author

Thanks! I look forward to using this asap.

@mojavelinux
Copy link
Member

Unfortunately, this isn't possible. That's because the document model doesn't know whether the alignment was set explicitly on the cell or is using an inherited or default value.

The only way this would work currently is if the theme forced the alignment. And I don't think that's what most users would expect.

We'd have to pursue this change upstream in Asciidoctor first in order to support it in Asciidoctor PDF.

@mojavelinux mojavelinux removed this from the v1.5.0.beta.1 milestone Jun 12, 2019
@mojavelinux
Copy link
Member

This depends on the following upstream issue: asciidoctor/asciidoctor#3335

@graphitefriction graphitefriction added this to the v2.1.x milestone May 16, 2022
@mojavelinux mojavelinux modified the milestones: v2.1.x, v2.2.x Jun 21, 2022
@mojavelinux mojavelinux modified the milestones: v2.2.x, v2.3.x Jul 22, 2022
@mojavelinux mojavelinux modified the milestones: v2.3.x, v3.0.x Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants